Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-423: bump mongodb to v5.0 in the ci #2446

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

williamlardier
Copy link
Contributor

Bump MongoDB to v5.0. Using the dev/8.7 branch as we do not need dedicated branches for mongodb anymore, unless we start using unsupported/deprecated features, as per previous discussions.

@bert-e
Copy link
Contributor

bert-e commented Sep 26, 2023

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 26, 2023

Incorrect fix version

The Fix Version/s in issue BB-423 contains:

  • 8.6.16

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.0

Please check the Fix Version/s of BB-423, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Sep 26, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamlardier williamlardier force-pushed the improvement/BB-423-bump-mongodb-to-5.0 branch from 0c01c57 to 0b628ee Compare January 4, 2024 13:03
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f819a6e) 63.14% compared to head (0b628ee) 63.14%.

Additional details and impacted files

Impacted file tree graph

see 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 65.61% <ø> (ø)
Core Library 62.18% <ø> (+0.01%) ⬆️
Ingestion 68.97% <ø> (ø)
Lifecycle 72.05% <ø> (ø)
Oplog Populator 73.87% <ø> (ø)
Replication 57.34% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@               Coverage Diff                @@
##           development/8.7    #2446   +/-   ##
================================================
  Coverage            63.14%   63.14%           
================================================
  Files                  191      191           
  Lines                12621    12621           
================================================
+ Hits                  7969     7970    +1     
+ Misses                4642     4641    -1     
  Partials                10       10           
Flag Coverage Δ
bucket-scanner 85.60% <ø> (ø)
ingestion 12.72% <ø> (ø)
lib 7.54% <ø> (+<0.01%) ⬆️
lifecycle 19.18% <ø> (ø)
notification 0.90% <ø> (ø)
replication 19.65% <ø> (ø)
unit 40.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-423.

Goodbye williamlardier.

@bert-e bert-e merged commit 0b628ee into development/8.7 Jan 4, 2024
13 checks passed
@bert-e bert-e deleted the improvement/BB-423-bump-mongodb-to-5.0 branch January 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants